Igc driver by hockeyfriend · Pull Request #2 · L4Re/ixl

hockeyfriend · 2026-02-10T09:10:30Z

Developed and tested the igc driver as part the bachelor thesis: "Generic aspects of porting a Linux Ethernet driver to the L4Re microkernel". The bachelor thesis will probably published in the coming month.

Also tested the igb driver with the i210 NIC and added support for it.

tmiemietz · 2026-02-19T08:24:42Z

Hi Paul,

Thanks for your work on the IXL driver! So let's get started to prepare your changes for being merged into the mainline version!

Unfortunately, your changes break IXL right in the first commit, as the constant IGB_DEV_ID_I210 is not defined. Also, compiling your pull request yields multiple warnings about unused variables and function parameters. Lastly, I would like to request your code changes to adhere to the style guidelines defined in the CONTRIBUTING.md file in this repository. Please follow the coding style of existing files, e.g. by minding the limit of 80 columns, using the existing style for source file headers, as well as taking care of minor things like alignment of comments.

So before looking into the code in more detail, these would be the first things to address. Once this is done, we can move further.

hockeyfriend · 2026-02-19T13:23:57Z

Hi Till,

already noticed the missing definition for the igb on monday but forgot to push it 😅. It should be fixed with commit 82acbb4.

I will fix the 80 character limit per line but other than that the code is identical with the code of the ixl igb. It should therefore already adhere to the contributing style guides.

I will also have look at the warnings and unused functions.

Thanks for your feedback.

Best Regards

Paul

tmiemietz · 2026-02-20T08:58:07Z

Hi Paul,

Could you update this PR in a way that the repository remains bisectable? I.e., I would like each commit to leave the code base in a state that allows for compiling it without errors and warnings. I particular this means that you would have to amend the first two commits with the fixes you committed later on.
Regarding the coding style stuff and other issues: Once the compilation issues are done, I will simply leave review comments at the spots that strike me :)

Thanks!

hockeyfriend · 2026-02-20T14:55:18Z

Hi Till,

This should now compile without problem and it is unified into one build-able commit.

I am curious about your feedback about the coding style as the igc driver is mainly copy of the ixl igb driver, which should already adhere to the coding style.

Best Regards

Paul

tmiemietz · 2026-02-23T09:08:24Z

Hi Paul,

Unfortunately, the first commit still does not compile, since the constant IGB_DEV_ID_I210 is not defined. You need to put your changes to lib/include/driver/igb/igb_type.h‎ into the first commit to create a fully bisectable PR. Could you update the PR accordingly?

Thanks!

hockeyfriend · 2026-02-23T22:48:00Z

The first commit is now also squashed into unified commit containing the i210 support for the igb as well as the igc driver code. I also added the igc and its supported nics to the readme.

tmiemietz

Hi Paul,

A first review of the proposed code changes is now complete. I did not go through all of the code yet. Nevertheless, could you please fix the issues brought up in the comments and also adapt the remainder of your PR in a way that it aligns with the style of the existing code base? I'll then give it another pass.

Thanks!

tmiemietz · 2026-02-27T12:48:51Z

lib/include/driver/igc/igc.h

@@ -0,0 +1,225 @@
+/**


Could you follow the formatting of the other header files? The first comment block should have a one-line description on what the file does, along with your name and the year(s) in that the file was modified. Also dump all of the information of version, date, file. Have a look at e.g. igb.h. The same goes for the layout of comment blocks (where each line should be preceded with an asterisk.

tmiemietz · 2026-02-27T12:50:19Z

lib/include/driver/igc/igc.h

+
+#include <stdbool.h>
+#include <l4/ixl/stats.h>
+


Delete that newline. The structure of includes is , , local header files with each category being separated by a newline.

tmiemietz · 2026-02-27T12:50:46Z

lib/include/driver/igc/igc.h

+
+#pragma once
+
+#include <stdbool.h>


Blank line after this include. Also, what is the reason for including stdbool.h here?

tmiemietz · 2026-02-27T12:54:06Z

lib/include/driver/igc/igc.h

+
+
+
+    /*** Functions                              ***/


Could you center these intermediate headings, with the righthand delimiter being aligned to column 80? In this way, the code looks way more fancy :)

tmiemietz · 2026-02-27T12:55:57Z

lib/include/driver/igc/igc.h

+    /**
+     * Disables an MSI for receive events.
+     *
+     * \param qid Index of the RX queue for that the corresponding MSI-X shall


For these multi-line doxygen statements: Could you align the descriptive text so that all lines of it start in the same column? Or does this break doxygen?

tmiemietz · 2026-02-27T13:30:41Z

lib/src/driver/igc/igc.cc

+        return 0;
+    }
+
+    if(status & IGC_STATUS_SPEED_2500)


Again spacing after keywords.

tmiemietz · 2026-02-27T13:31:01Z

lib/src/driver/igc/igc.cc

+	if (status & IGC_STATUS_FD) {
+		duplex = FULL_DUPLEX;
+		//ixl_debug("Full Duplex\n");
+	} else {


Else on new line.

tmiemietz · 2026-02-27T13:31:25Z

lib/src/driver/igc/igc.cc

+	status = get_reg32(baddr[0], IGC_STATUS);
+	if (status & IGC_STATUS_FD) {
+		duplex = FULL_DUPLEX;
+		//ixl_debug("Full Duplex\n");


Drop the comments if they are debugging artifacts.

tmiemietz · 2026-02-27T13:31:51Z

lib/src/driver/igc/igc.cc

+
+struct mac_address Igc_device::get_mac_addr(void) {
+
+    ixl_info("Entering...");


Drop those debugging things altogether.

tmiemietz · 2026-02-27T13:35:18Z

lib/src/driver/igc/igc.cc

I have reviewed at least the first half of the file. Even though the style guide in CONTRIBUTING.md is not complete: Could you please take a look at existing source files and adhere to the coding style you find in them? This holds e.g. for the placement of the else keyword / placement of opening braces, spacing rules, or adhering to the code boundary of 80 columns. Also please mind the proper naming of variables. Debugging code should be removed.

tmiemietz self-assigned this Feb 19, 2026

tmiemietz self-requested a review February 19, 2026 08:01

tmiemietz added the enhancement New feature or request label Feb 19, 2026

hockeyfriend force-pushed the igc-driver branch from da1be6a to 5f5722d Compare February 20, 2026 14:47

added igc device driver and added support for i210 Nics for igb driver

78f631c

hockeyfriend force-pushed the igc-driver branch from 5f5722d to 78f631c Compare February 23, 2026 22:44

tmiemietz requested changes Feb 27, 2026

View reviewed changes


		struct mac_address Igc_device::get_mac_addr(void) {

		ixl_info("Entering...");


		#include <stdbool.h>
		#include <l4/ixl/stats.h>


		#pragma once

		#include <stdbool.h>

Conversation

hockeyfriend commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmiemietz commented Feb 19, 2026

Uh oh!

hockeyfriend commented Feb 19, 2026

Uh oh!

tmiemietz commented Feb 20, 2026

Uh oh!

hockeyfriend commented Feb 20, 2026

Uh oh!

tmiemietz commented Feb 23, 2026

Uh oh!

hockeyfriend commented Feb 23, 2026

Uh oh!

tmiemietz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hockeyfriend commented Feb 10, 2026 •

edited

Loading